hardcoded 5s CLI child timeout breaks upload/download/exec (not just drive-auth) #11
Labels
No labels
area/backup
area/cli
area/docs
area/dsh
area/forgejo
area/host
area/mcp
area/plugin
area/security
area/ux
needs-operator
priority/later
priority/next
priority/now
type/bug
type/research
type/task
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
dsh-plugins/dsh-colab#11
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Same 5 s hard timeout as #10, but it also breaks non-interactive file operations, so it is not only a drive-auth bug.
Repro (fresh T4, Drive already mounted via manual
colab drivemount):A 13 MB upload over the Drive FUSE mount routinely takes 10-60 s; the CLI child is killed at 5 s. The same applies to
colab_download,colab_exec(any real script >5 s),colab_run,colab_drive_auth(#10).Expected
timeout_s.exec_timeout,auth_pending, ...) with the raw tail, notcli_timeoutat 5 s.colab_upload) should apply to the whole operation, not a 5 s window.Suspect
A shared
runCli()helper with a hardcoded 5 000 ms child timeout (orexecFiledefault) used by every tool.Suggested fix + test
cliTimeoutMsplugin config (default 120000) + per-tool override;Impact
v0 is effectively unusable for real jobs until this is fixed: every meaningful CLI op exceeds 5 s. Workaround is raw
colab ...in a shell, which is what the plugin was supposed to replace.Fixed in 0.1.3 (
9ce6715, tagv0.1.3). It was the same hardcoded 5 s listing budget: uploads usedcommandTimeoutMs(180 s) but the overwrite guard/verificationcolab lsused 5 s, and a listing can queue behind a busy kernel or a settling Drive mount.What changed:
colab lsuses a newlistTimeoutMsconfig (default 60 s);commandTimeoutMs(default 180 s) and map a CLI wall-clock timeout totransfer_failedwith a hint to retry or raisecommandTimeoutMs— no more barecli_timeout;transfer_failed;listTimeoutMs; the 13 MB bundle path is covered by the fake CLI tests.Upgrade:
dsh plugin --profile web add --registry https://git.pvlb.dev/api/packages/dsh-plugins/npm/ dsh-colab@0.1.3, restart the profile, and retest the upload. If a transfer legitimately exceeds 180 s, raisecommandTimeoutMsin the plugin config.